Fix flakey invariant and add mathematic require in Lender (#162)

aloelabs · Sep 18, 2023 · 9568095 · 9568095
1 parent 4d7ea7b
commit 9568095
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/core/src/Lender.sol b/core/src/Lender.sol
@@ -61,7 +61,7 @@ contract Lender is Ledger {
 
     /// @notice Sets the `rateModel` and `reserveFactor`. Only the `FACTORY` can call this.
     function setRateModelAndReserveFactor(IRateModel rateModel_, uint8 reserveFactor_) external {
-        require(msg.sender == address(FACTORY));
+        require(msg.sender == address(FACTORY) && reserveFactor_ > 0);
         rateModel = rateModel_;
         reserveFactor = reserveFactor_;
     }

diff --git a/core/test/invariants/LenderInvariants.t.sol b/core/test/invariants/LenderInvariants.t.sol
@@ -199,9 +199,9 @@ contract LenderInvariantsTest is Test {
             address user = lenderHarness.holders(i);
 
             // NOTE: As price per share increases (i.e., each share converts to more and more underlying assets),
-            // this assertion may become flakey due to rounding. Allowing for rounding error of 2 seems sufficient
+            // this assertion may become flakey due to rounding. Allowing for rounding error of 3 seems sufficient
             // in our testing. Just make sure the contract itself never assumes principle < underlyingBalance
-            assertLe(lender.principleOf(user), lender.underlyingBalance(user) + 2);
+            assertLe(lender.principleOf(user), lender.underlyingBalance(user) + 3);
         }
     }