Fixed the two broken references to SweetAlert #3943
Conversation
The urls I used where the best ones I managed to find. (I'm sure there are better ones somewhere, but it was surprisingly difficult finding them.)
|
Sorry, I should have mentioned this relates to http://visjs.org/examples/timeline/editing/editingItemsCallbacks.html, which is broken due to 404s for the SweetAlert references. |
|
Sweetalert introduced a lot of breaking changes, did you test with the 2.x releases? Mine broke with it, maybe use the links from https://www.jsdelivr.com/package/npm/sweetalert?version=1.1.3&path=dist |
|
Oh, I made a bad assumption here. I just assumed the files had changed locations and that I just needed to update the references so I just updated the urls and PR'd. So what do you say, are these reasonable urls instead? |
|
Yes, I would say so. |
|
hi @sandebert |
* Fixed the two broken references to SweetAlert The urls I used where the best ones I managed to find. (I'm sure there are better ones somewhere, but it was surprisingly difficult finding them.) * Changed the urls again
The urls I used where the best ones I managed to find. (I'm sure there are better ones somewhere, but it was surprisingly difficult finding them.)