This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
[Timeline] Allow normal page scrolling over timeline #3818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Thanks you! |
villepalo
pushed a commit
to villepalo/vis
that referenced
this pull request
Sep 13, 2018
villepalo
pushed a commit
to villepalo/vis
that referenced
this pull request
Sep 17, 2018
mojoaxel
pushed a commit
to visjs/vis_original
that referenced
this pull request
Jun 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds/fixes #3734. Since I believe that this should be the expected behaviour, I don't think it requires an extra example etc, if reviewers disagree, I can add one.
As the linked ticket states, you can't scroll the page while the mouse is over the timeline (even if the timeline is doing nothing with that scroll). This PR changes it so that as-long as the timeline isn't zooming or scrolling, then the page will scroll (Timeline won't eat the event).