This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
[Timeline] Fix react integration, fix content applying mechanics #3760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yotamberk
approved these changes
Jan 6, 2018
mojoaxel
pushed a commit
to visjs/vis_original
that referenced
this pull request
Jun 9, 2019
…ende#3760) * Delete unnecessary appending content to the node * Remove unndecessary rerender of React component
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Today i found two little problems with groups on timeline.
Commit messages i guess are pretty good explain what i did.
In the case of React, there was problem with unnecessary rerender of content.
That is the place where content was already rendered
And that is the place where it has rerendered all the time before my change.
Case was tested on the expalmple from the docs of vis.