Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Adding unit tests for lib/shared #3600

Merged
merged 22 commits into from
Nov 4, 2017
Merged

Adding unit tests for lib/shared #3600

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
b450758
Adds code coverage report the output of `npm test` and adds detailed …
Oct 15, 2017
b50ddc5
Switch over to using functions in lib/ rather than dist/, so that cod…
Oct 15, 2017
bbcaa78
Import vis at the top level to keep ItemSet passing
Oct 15, 2017
6c8cf80
Remove requirement for dist/vis in TimelineItemSet
Oct 15, 2017
294525c
Adds tests for Popup
Oct 17, 2017
319fced
Tests and sinon dependency introduced
Oct 21, 2017
989bfd2
Code changes to modules to tighten up code
Oct 21, 2017
3aae9fc
Merge branch 'develop' into mbroad/unittest/lib/shared
Oct 21, 2017
a56cd13
Merge branch 'develop' into mbroad/code-coverage
Oct 21, 2017
4b766a5
Merge branch 'mbroad/code-coverage' into mbroad/unittest/lib/shared
Oct 21, 2017
e25d2e2
Corrects broken tests and adds more tests to ColorPicker
Oct 21, 2017
4c68bae
Adds additional tests to DataSet
Oct 21, 2017
139bc86
Adds tests for uuid
Oct 21, 2017
429b63c
Removes unused functions from util
Oct 21, 2017
6288a41
Adds tests for utils: recursiveDomDelete, isDate, convert and isType
Oct 22, 2017
645fc91
removes redundant code
Oct 22, 2017
c19e524
Adds additional util tests
Oct 23, 2017
f81eef5
Address spacing, and unnecessary tests
Oct 25, 2017
031d640
Correct test description
Oct 25, 2017
0f8455f
Adds isDate tests
Oct 27, 2017
8303487
Adds sanity check assertions to popup destroy tests
Oct 27, 2017
388edb5
Merge branch 'develop' into mbroad/unittest/lib/shared
Oct 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/shared/Configurator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,7 @@ class Configurator {
this.options.filter = options.join();
}
else if (typeof options === 'object') {
if (options == null)
{
if (options == null) {
throw new TypeError('options cannot be null');
}
if (options.container !== undefined) {
Expand Down
30 changes: 29 additions & 1 deletion test/ColorPicker.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ describe('ColorPicker', function () {
it('prevents non-functions from being set as callback', function () {
var colorPicker = new ColorPicker();
assert.throws(function () {colorPicker.setUpdateCallback(null);}, Error, null);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm inclined to add the usual suspects here: 'null, undefined, [1,2,3], {a: 42}, 42, "meow"`.

Actually, I would consider being able to undo a callback (with null and/or undefined) a feature here.

Same applies to setCloseCallback().

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

assert.throws(function () {colorPicker.setUpdateCallback(undefined);}, Error, null);
assert.throws(function () {colorPicker.setUpdateCallback([1, 2, 3]);}, Error, null);
assert.throws(function () {colorPicker.setUpdateCallback({a: 42});}, Error, null);
assert.throws(function () {colorPicker.setUpdateCallback(42);}, Error, null);
assert.throws(function () {colorPicker.setUpdateCallback('meow');}, Error, null);
});
});

Expand All @@ -67,6 +72,11 @@ describe('ColorPicker', function () {
it('prevents non-functions from being set as callback', function () {
var colorPicker = new ColorPicker();
assert.throws(function () {colorPicker.setCloseCallback(null);}, Error, null);
assert.throws(function () {colorPicker.setCloseCallback(undefined);}, Error, null);
assert.throws(function () {colorPicker.setCloseCallback([1, 2, 3]);}, Error, null);
assert.throws(function () {colorPicker.setCloseCallback({a: 42});}, Error, null);
assert.throws(function () {colorPicker.setCloseCallback(42);}, Error, null);
assert.throws(function () {colorPicker.setCloseCallback('meow');}, Error, null);
});
});

Expand All @@ -75,19 +85,29 @@ describe('ColorPicker', function () {
it('runs updateCallback when applied', function () {
var callback = sinon.spy();
var colorPicker = new ColorPicker();
var colorBeforeHide = colorPicker.color;
colorPicker.setUpdateCallback(callback);
colorPicker.applied = true;
colorPicker._hide();
assert.equal(callback.callCount, 1);
assert.deepEqual(colorBeforeHide, colorPicker.previousColor);
});

it('does not run updateCallback when not applied', function () {
var callback = sinon.spy();
var colorPicker = new ColorPicker();
var colorBeforeHide = colorPicker.color;
colorPicker.setUpdateCallback(callback);
colorPicker.applied = false;
colorPicker._hide();
assert.equal(callback.callCount, 0);
assert.deepEqual(colorBeforeHide, colorPicker.previousColor);
});

it('does not set previous color when storePrevious is false', function () {
var colorPicker = new ColorPicker();
colorPicker._hide(false);
assert.deepEqual(colorPicker.previousColor, undefined);
});
});

Expand All @@ -114,9 +134,14 @@ describe('ColorPicker', function () {
assert.deepEqual(colorPicker.color, { r: 255, g: 255, b: 255, a: 1 });
});

it('throws error when color is null', function () {
it('throws error when color is a bad value', function () {
var colorPicker = new ColorPicker();
assert.throws(function () {colorPicker.setColor(null);}, Error, null);
assert.throws(function () {colorPicker.setColor(undefined);}, Error, null);
assert.throws(function () {colorPicker.setColor([1, 2, 3]);}, Error, null);
assert.throws(function () {colorPicker.setColor({a: 42});}, Error, null);
assert.throws(function () {colorPicker.setColor(42);}, Error, null);
assert.throws(function () {colorPicker.setColor('meow');}, Error, null);
});

it('handles html color string', function () {
Expand Down Expand Up @@ -165,15 +190,18 @@ describe('ColorPicker', function () {
colorPicker.show();
assert(callback.called);
assert(callback.calledOnce);
assert(colorPicker.generated)
});

it('resets applied state and frame display style to `block`', function () {
var colorPicker = new ColorPicker();
colorPicker.show();
assert.equal(colorPicker.applied, false);
assert.equal(colorPicker.frame.style.display, 'block');
assert(colorPicker.generated)
});
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On account of thoroughness (which you are, very), I would expect test it('generates the hue circle') here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're not going to do this?


describe('_save', function () {

it('triggers updateCallback', function () {
Expand Down
4 changes: 2 additions & 2 deletions test/Configurator.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ describe('Configurator', function () {

it('sets extends options with default options', function () {
var config = new Configurator();
assert.equal(JSON.stringify(config.options), JSON.stringify(config.defaultOptions));
assert.deepEqual(config.options, config.defaultOptions);
});
});

Expand All @@ -35,7 +35,7 @@ describe('Configurator', function () {
it('with undefined will not modify defaults', function () {
var config = new Configurator(Network, this.container);
config.setOptions();
assert.equal(JSON.stringify(config.options), JSON.stringify(config.defaultOptions));
assert.deepEqual(config.options, config.defaultOptions);
});

it('with undefined will set enabled to false', function () {
Expand Down
40 changes: 8 additions & 32 deletions test/DataSet.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ describe('DataSet', function () {
assert.equal(minValue, null);
});

it('ignores undefined values', function () {
it('handles undefined values', function () {
var dataset = new DataSet([{id: undefined}, {id: 1}, {id: 2}, {id: 3}]);
var minValue = dataset.min('id');
assert.deepEqual(minValue, {id: 1});
Expand All @@ -429,14 +429,9 @@ describe('DataSet', function () {
var minValue = dataset.min('id');
assert.deepEqual(minValue, {id: 10000000000000001});
});

xit('handles big values - but not really, because of javascript number handling', function () {
var dataset = new DataSet([{id: -10000000000000001}, {id: -10000000000000002}, {id: -10000000000000003}]);
var minValue = dataset.min('id');
assert.deepEqual(minValue, {id: -10000000000000003});
assert.equal('' + minValue.id, '-10000000000000003')
});
});


describe('max', function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline (I usually do 2 here)


it('finds the maximum value', function () {
Expand All @@ -451,24 +446,11 @@ describe('DataSet', function () {
assert.equal(maxValue, null);
});

it('ignores undefined values', function () {
it('handles undefined values', function () {
var dataset = new DataSet([{id: undefined}, {id: 1}, {id: 2}, {id: 3}]);
var maxValue = dataset.max('id');
assert.deepEqual(maxValue, {id: 3});
});

xit('handles big values - but not really, because of javascript number handling', function () {
var dataset = new DataSet([{id: 10000000000000001}, {id: 10000000000000002}, {id: 10000000000000003}]);
var maxValue = dataset.max('id');
assert.deepEqual(maxValue, {id: 10000000000000003});
assert.equal('' + maxValue.id, '10000000000000003')
});

xit('handles negative values - This does not work because of javascript', function () {
var dataset = new DataSet([{id: -10000000000000001}, {id: -10000000000000002}, {id: -10000000000000003}]);
var maxValue = dataset.max('id');
assert.deepEqual(maxValue, {id: -10000000000000001});
});
});

describe('distinct', function () {
Expand All @@ -485,22 +467,16 @@ describe('DataSet', function () {
assert.deepEqual(distinctValues, []);
});

it('ignores undefined values', function () {
it('handles undefined values', function () {
var dataset = new DataSet([{val: undefined}, {val: 1}, {val: 2}, {val: 3}]);
var distinctValues = dataset.distinct('val');
assert.deepEqual(distinctValues, [1, 2, 3]);
});

xit('handles big values - but not really, because of javascript number handling', function () {
var dataset = new DataSet([{val: 10000000000000001}, {val: 10000000000000002}, {val: 10000000000000003}, {val: 10000000000000004}]);
it('handles duplicate values', function () {
var dataset = new DataSet([{val: 1}, {val: 1}, {val: 2}, {val: 3}]);
var distinctValues = dataset.distinct('val');
assert.deepEqual(distinctValues, [ 10000000000000000, 10000000000000002, 10000000000000003, 10000000000000004]);
});

xit('handles negative values - This does not work because of javascript', function () {
var dataset = new DataSet([{val: -10000000000000001}, {val: -10000000000000002}, {val: -10000000000000003}, {val: -10000000000000004}]);
var distinctValues = dataset.distinct('val');
assert.deepEqual(distinctValues, [ -10000000000000000, -10000000000000002, -10000000000000003, -10000000000000004]);
assert.deepEqual(distinctValues, [1, 2, 3]);
});
});

Expand Down
Loading