This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Network: Prevent crash when dataChanged is triggered during initialization #3568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etting of options Fixes almende#3562. Options `hidden` and `physics` can emit a `_dataChanged` event within `setOptions()`. If this happens when setting options during the initialization of the `Network` instance, this leads to an error thrown, because there is no DataSet instance connected yet to the instance. This bug was introduced in `v4.21.0`. Unit tests have been added for this case.
wimrijnders
changed the title
yotamberk
approved these changes
Oct 13, 2017
mojoaxel
pushed a commit
to visjs/vis_original
that referenced
this pull request
Jun 9, 2019
…ation (almende#3568) * Network: Prevent crash when dataChanged is triggered during initial setting of options Fixes almende#3562. Options `hidden` and `physics` can emit a `_dataChanged` event within `setOptions()`. If this happens when setting options during the initialization of the `Network` instance, this leads to an error thrown, because there is no DataSet instance connected yet to the instance. This bug was introduced in `v4.21.0`. Unit tests have been added for this case. * Edited comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3562.
Options
hiddenandphysicscan emit a_dataChangedevent withinsetOptions().If this happens when setting options during the initialization of the
Networkinstance, this leadsto an error thrown, because there is no DataSet instance connected yet to the instance.
This bug was introduced in
v4.21.0. Unit tests have been added for this case.