Show attachments in modal view #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-boris
reviewed
Jul 23, 2017
| if (attachment) { | ||
| this.routeState.set('attachment', attachment); | ||
| } else { | ||
| this.routeState.unset('attachment', {silent: true}); |
There was a problem hiding this comment.
Silent is usually an anti-pattern. Can you not to use this option?
There was a problem hiding this comment.
You can add a check into highlightSelectedAttachment method instead.
|
Visual review
I don't like the current inline display. My suggestion
|
|
And my constant reminder about tab content: Steps should be on the first tab. I think this change should be done the first, before all other improvements with inline attachments. |
|
@just-boris |
|
|
|
|
|
|
@just-boris i am done |
baev
approved these changes
Jul 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//: # (
. Thank you so much for sending us a pull request!
.
. Make sure you have a clear name for your pull request.
. The name should start with a capital letter and no dot is required in the end of the sentence.
. To link the request with isses use the following notation: (fixes #123, fixes #321)
.
. An example of good pull request names:
. - Add Russian translation (fixes #123)
. - Add an ability to disable default plugins
. - Support emoji in test descriptions
)
Context
Checklist