Take nested attachments into account when doing the screenshots diff #1869
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The screen-diff plugin works great but it doesn't take into account attachments that are nested in an Allure step, or that are attached to the before-/after-test stages. This PR extends the
findImage
function of the plugin to take all the steps/stages into account.I tested it locally, as can be seen on the following screenshot (black boxes hide private information, red lines highlighting the change):
Checklist