Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take nested attachments into account when doing the screenshots diff #1869

Conversation

nonatomiclabs
Copy link

Context

The screen-diff plugin works great but it doesn't take into account attachments that are nested in an Allure step, or that are attached to the before-/after-test stages. This PR extends the findImage function of the plugin to take all the steps/stages into account.

I tested it locally, as can be seen on the following screenshot (black boxes hide private information, red lines highlighting the change):
allure-screenshot

Checklist

  • Sign Allure CLA
  • Provide unit tests: not sure how to add them, as I didn't find tests for this plugin

@baev
Copy link
Member

baev commented Dec 22, 2022

Screen Diff plugin is deprecated. We suggest you use imagediff attachments instead. See #1145 for details

@nonatomiclabs
Copy link
Author

Thanks a lot, I'll have a look at imagediff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants