[newman-reporter-allure] Fix: Resolved the issue of formatting in JSON response content displaying in Allure reports. #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
epszaw
requested changes
Nov 23, 2023
| const attachment = this.allureRuntime.writeAttachment(response.body, { | ||
| contentType: ContentType.TEXT, | ||
| contentType: contentType, |
There was a problem hiding this comment.
Just leave the property without shadow:
{ contentType }| let contentType = ContentType.TEXT; | ||
|
|
||
| // Check if the response content type is JSON | ||
| const contentTypeHeader = args.item.responses.members[0]?.getHeader('Content-Type'); |
There was a problem hiding this comment.
Set empty string as fallback value to eliminate nullish checks
|
|
||
| // Check if the response content type is JSON | ||
| const contentTypeHeader = args.item.responses.members[0]?.getHeader('Content-Type'); | ||
| if (contentTypeHeader && contentTypeHeader.toLowerCase().includes('application/json')) { |
There was a problem hiding this comment.
It's ok, but imo, better to use regexp:
/application\/json/i.test(contentTypeHeader)
win5923
force-pushed
the
master
branch
2 times, most recently
from
66e46a4 to
92daa86
Compare
|
@epszaw Is there anything else that needs to be modified? edit: Correcting some typo errors. |
|
@win5923 please, check typescript errors and linters |
win5923
force-pushed
the
master
branch
5 times, most recently
from
fc3ad9a to
5616d17
Compare
…ying in Allure reports.
|
Fixed Property 'response' does not exist on type '{ item: Item; }'. |
…ying in Allure reports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When the
Content-Typeof a response body isapplication/json, the formatting should be normal.Screenshot
Postman:
Postman Response body:
Allure report (anonymised for privacy):
Checklist