Add auto-detect of attachments extension [playwright]

packages/allure-js-commons/src/AllureRuntime.ts

@@ -1,4 +1,5 @@
 import { PathLike } from "fs";
+import { extname } from "path";
 import { v4 as randomUUID } from "uuid";
 import { AllureConfig } from "./AllureConfig";
 import { AllureGroup } from "./AllureGroup";
@@ -52,6 +53,21 @@ export class AllureRuntime {
     fromPath: PathLike,
     options: ContentType | string | AttachmentOptions,
   ): string {
+    if (typeof fromPath === "string") {
+      const fileExtension = extname(fromPath).substring(1);
+      if (typeof options === "string") {
+        options = {
+          fileExtension: fileExtension,
+          contentType: options,
+        };
+      } else {
+        options = {
+          fileExtension: fileExtension,
+          ...options,
+        };
+      }
+    }
+
     const fileName = buildAttachmentFileName(options);
     this.writer.writeAttachmentFromPath(fromPath, fileName);
     return fileName;

packages/allure-playwright/src/index.ts

@@ -138,8 +138,12 @@ class AllureReporter implements Reporter {
         trace,
       };
     }
+
     for (const attachment of result.attachments) {
       if (!attachment.body && !attachment.path) {
+        if (!process.env.PW_ALLURE_POST_PROCESSOR_FOR_TEST) {
+          console.log(`Attachment ${attachment.name} has no body or path`); // eslint-disable-line no-console
+        }
         continue;
       }
 
@@ -169,8 +173,12 @@ class AllureReporter implements Reporter {
         fileName = runtime.writeAttachment(attachment.body, attachment.contentType);
       } else {
         if (!fs.existsSync(attachment.path!)) {
+          if (!process.env.PW_ALLURE_POST_PROCESSOR_FOR_TEST) {
+            console.log(`File does not exist: ${attachment.path!}`); // eslint-disable-line no-console
+          }
           continue;
         }
+
         fileName = runtime.writeAttachmentFromPath(attachment.path!, attachment.contentType);
       }
 

packages/allure-playwright/test/attachment.spec.ts

@@ -14,8 +14,8 @@
  * limitations under the License.
  */
 
-import fs from "fs";
 import { expect, test } from "./fixtures";
+import * as fs from "fs";
 
 test("should not throw on missing attachment", async ({ runInlineTest }) => {
   const result = await runInlineTest(
@@ -80,3 +80,30 @@ test("should add snapshots correctly and provide a screenshot diff", async ({
     ]),
   );
 });
+
+test("should correctly and automatically detect file extension", async ({
+  runInlineTest,
+  attachment,
+}) => {
+  const result = await runInlineTest(
+    {
+      "a.test.ts": `
+      import test from '@playwright/test';
+      test('should add attachment', async ({}, testInfo) => {
+        testInfo.attachments.push({
+          name: 'sound',
+          path: 'a.test.ts-snapshots/file-sound.mp3',
+          contentType: 'audio/mpeg'
+        })
+      });
+      `,
+      "a.test.ts-snapshots/file-sound.mp3": fs.readFileSync(attachment("empty.mp3")),
+    },
+    (writer) => {
+      return writer.tests[0].attachments;
+    },
+  );
+
+  expect(result.length).toBe(1);
+  expect(result[0].source).toEqual(expect.stringMatching(/.mp3$/));
+});