fix: remove ansi characters in steps statusDetails #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todti
force-pushed
the
fix_ansi_in_statusDetails
branch
from
051bfe8 to
6232946
Compare
epszaw
approved these changes
Aug 1, 2024
| @@ -184,16 +184,15 @@ export abstract class MessageTestRuntime implements TestRuntime { | |||
|
|
|||
| return result; | |||
| } catch (err) { | |||
| const { message, stack } = err as Error; | |||
| const details = getMessageAndTraceFromError(err as Error); | |||
|
|
|||
| await this.sendMessage({ | |||
| type: "step_stop", | |||
| data: { | |||
| status: getStatusFromError(err as Error), | |||
| stop: Date.now(), | |||
| statusDetails: { | |||
There was a problem hiding this comment.
You can just assign details or call the function right in the object:
// ...
statusDetails: getMessageAndTraceFromError(err as Error);
// ...
baev
approved these changes
Aug 1, 2024
|
That fixes the problem in the following packages, which use
Allure-cypress might still be affected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Checklist