Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(allure-jest): compatibility with Jest >=24.8.0 #1054

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

delatrie
Copy link
Collaborator

@delatrie delatrie commented Jul 8, 2024

Context

The PR extends the range of supported Jest versions to >=24.8.0. Versions before 24.8.0 aren't supported because they ignore an environment's handleTestEvent method.

Note

When using Jest lower than 27.0.0, the testRunner: "jest-circus/runner" must be specified in the config. That's why I've added jest-circus as an optional peer dependency. Starting from 27.0.0, Jest uses jest-circus by default without the need to install it separately.

The main motivation for the change is that older versions (especially 27) still have quite notable download counts:

Fixes #1010

@delatrie delatrie added the type:new feature New feature or request label Jul 8, 2024
@delatrie delatrie requested a review from baev July 8, 2024 13:39
@github-actions github-actions bot added the theme:jest Jest related issue label Jul 8, 2024
Include jest-circus as an optional peer dep for jest prior to v27.
@delatrie delatrie force-pushed the jest-pre28-compat branch from dce2a3a to 2a475e9 Compare July 8, 2024 13:42
@baev baev merged commit dc12bdc into main Jul 9, 2024
7 checks passed
@baev baev deleted the jest-pre28-compat branch July 9, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:jest Jest related issue type:new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'testEnvironmentOptions')
2 participants