Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix devDependency version duplication in monorepo #1026

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

vovsemenv
Copy link
Collaborator

@vovsemenv vovsemenv commented Jul 1, 2024

Fix duplicated package versions in monorepo.
linted by https://www.npmjs.com/package/sherif

Maybe it would be cool to add this in CI lint step

$ allure-js git:(main) npx sherif --fix                                   
5 issues found in ./:

 ✓ fixed Dependency @types/node has multiple versions defined in the workspace. multiple-dependency-versions
  ./packages
      allure-codeceptjs         ^20.6.3   ↓ lowest
      allure-cucumberjs         ^20.6.3   ↓ lowest
      allure-cypress            ^20.6.3   ↓ lowest
      allure-jasmine            ^20.6.3   ↓ lowest
      allure-jest               ^20.6.3   ↓ lowest
      allure-js-commons         ^20.6.3   ↓ lowest
      allure-mocha              ^20.6.3   ↓ lowest
      allure-playwright         ^20.6.3   ↓ lowest
      allure-vitest             ^20.6.3   ↓ lowest
      newman-reporter-allure    20.14.2   ↑ highest

 ✓ fixed Dependency npm-run-all2 has multiple versions defined in the workspace. multiple-dependency-versions
  ./packages
      allure-cypress            ^6.0.0   ↓ lowest
      allure-js-commons         ^6.0.0   ↓ lowest
      allure-codeceptjs         ^6.1.2   ↑ highest
      allure-cucumberjs         ^6.1.2   ↑ highest
      allure-jasmine            ^6.1.2   ↑ highest
      allure-jest               ^6.1.2   ↑ highest
      allure-mocha              ^6.1.2   ↑ highest
      allure-playwright         ^6.1.2   ↑ highest
      allure-vitest             ^6.1.2   ↑ highest
      newman-reporter-allure    ^6.1.2   ↑ highest

 ✓ fixed Dependency ts-node has multiple versions defined in the workspace. multiple-dependency-versions
  ./packages
      allure-cucumberjs         ^10.9.1   ↓ lowest
      allure-jest               ^10.9.1   ↓ lowest
      allure-js-commons         ^10.9.1   ↓ lowest
      allure-mocha              ^10.9.1   ↓ lowest
      newman-reporter-allure    ^10.9.1   ↓ lowest
      allure-codeceptjs         ^10.9.2   ↑ highest
      allure-cypress            ^10.9.2   ↑ highest

 ✓ fixed Dependency expect has multiple versions defined in the workspace. multiple-dependency-versions
  ./packages
      allure-js-commons         ^29.5.0   ↓ lowest
      allure-codeceptjs         ^29.7.0   ↑ highest
      newman-reporter-allure    ^29.7.0   ↑ highest

 ✓ fixed Dependency @types/jasmine has multiple versions defined in the workspace. multiple-dependency-versions
  ./packages
      allure-jasmine            ^3.3.12   ↓ lowest
      allure-codeceptjs         ^5.1.4   ↑ highest

5 issues found (0 ⨯, 0 ⚠️, 5 ✓) across 10 packages in 1.958620958s.

@vovsemenv vovsemenv added the type:dependencies Pull requests that update a dependency file label Jul 1, 2024
@github-actions github-actions bot added theme:api Javascript API related issue theme:mocha Mocha related issue theme:jest Jest related issue theme:cucumberjs CucumberJS related issue theme:jasmine Jasmine related issue theme:playwright theme:newman theme:codeceptjs theme:vitest labels Jul 1, 2024
@epszaw epszaw merged commit 82a3dba into main Jul 1, 2024
9 checks passed
@epszaw epszaw deleted the fix-monorepo-duplications branch July 1, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:api Javascript API related issue theme:codeceptjs theme:cucumberjs CucumberJS related issue theme:jasmine Jasmine related issue theme:jest Jest related issue theme:mocha Mocha related issue theme:newman theme:playwright theme:vitest type:dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants