-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facelift: split plugin to several ones, implement aggregation, migrate to Kotlin #61
Conversation
allureDownload takes ~15 megabytes so test executions consume noticeable space
UPD: renamed Unfortunately, the naming of plugins {
id("io.qameta.allure-collect") // <-- this probably needs renaming
id("io.qameta.allure-report")
}
allure {
collect { // <-- this clashes with Groovy's Object.collect(Closure)
... Does anybody have other ideas for the name? |
JFrog announced they would keep read-only JCenter: https://twitter.com/steveonjava/status/1387072410868797440 I am not sure if it makes sense to support "pre 2.8.0 allure versions" though. I guess the users could just upgrade. For now, I removed all jcenter-related tests. |
Note: the main plugin project uses Gradle 6.8.3 for better backward compatibility with previous Gradle verisons. See gradle/gradle#16781 Sandbox uses Gradle 7 to see that the plugin is usable from Gradle 7
…e easier to understand
@baev lgtm? |
@eroshenkoam is there any information on when this change is going to be released? |
@vlsi maybe some insight from you on when this change might be released? |
@eroshenkoam are there any updates regarding release date of this change? We would love to use latest Gradle with Allure in our project... |
This PR reworks allure-gradle plugin implementation solving all (?) the currently open issues, and making the use more predictable and user-friendly.
Note: GitHub Actions are not configured for
allure-gradle
yet, so you could check CI results at https://github.com/vlsi/allure-gradle/actions and in Gradle Build Scan (see link at the end of the run like https://scans.gradle.com/s/ylw72oz2r5nso/tests )Here's the updated readme: https://github.com/vlsi/allure-gradle/tree/facelift
The PR is more-or-less ready.
Open questions
allure-selenide
) be auto-detected by default?Missing bits
Tests
There are test failures, however, it looks like they identify true bugs:
TestNgSpiOffTest.allureReportIsNotGenerated
collects results even whenspiOff
dependency is used:UPD: ComponentMetadataHandler.withModule.withVariant.withDependencies.add should allow requesting a capability for the added dependency gradle/gradle#17035 cause Gradle to ignore the classifier when adding a dependency with a metadata rule.
https://scans.gradle.com/s/l6jgwoiedmtky/tests/:allure-plugin:test/io.qameta.allure.gradle.allure.TestNgSpiOffTest/allureReportIsNotGenerated?top-execution=1
junit5
does not collect test results (too old JUnit version? a bug in the new allure-junit5?):UPD:
allureJavaVersion=2.13.5
collects data, andallureJavaVersion=2.13.6
fails to collect JUnit5 data.https://scans.gradle.com/s/l6jgwoiedmtky/tests/:allure-plugin:test/io.qameta.allure.gradle.allure.DependenciesTest/shouldCreateAllureResults%5Bsrc%2Fit%2Fjunit5%20%5B5.0%5D%5D?top-execution=1
Notes
Checklist