Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for arguments of type Closure #110

Merged
merged 5 commits into from
Mar 27, 2023
Merged

Conversation

alnivv-vi
Copy link
Contributor

@alnivv-vi alnivv-vi commented Jan 23, 2023

fix error for executeInSelenium function (Closure as argument)

fixes #109

@CLAassistant
Copy link

CLAassistant commented Jan 23, 2023

CLA assistant check
All committers have signed the CLA.

@baev baev added the type:bug label Jan 26, 2023
@baev
Copy link
Member

baev commented Jan 26, 2023

@alnivv-vi, thanks for the PR. Could you please fix the build?

@alnivv-vi
Copy link
Contributor Author

@baev check please

src/Internal/ArgumentAsString.php Outdated Show resolved Hide resolved
src/Internal/ArgumentAsString.php Outdated Show resolved Hide resolved
src/Internal/ArgumentAsString.php Outdated Show resolved Hide resolved
src/Internal/ArgumentAsString.php Outdated Show resolved Hide resolved
src/Internal/ArgumentAsString.php Outdated Show resolved Hide resolved
@baev baev changed the title closure fix Add support for arguments of type Closure Mar 27, 2023
@baev baev merged commit 8855689 into allure-framework:main Mar 27, 2023
@baev
Copy link
Member

baev commented Mar 27, 2023

@alnivv-vi thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error for executeInSelenium function (Closure as argument)
3 participants