Fix race condition between instances of svm in setting up the SVM directory #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Foundry in CI, I encountered an issue where if multiple instances of Foundry were launched at the same time, compiling Solidity source in different directories, one would sometimes fail with an
AlreadyExistserror.Upon investigating, I noticed that there is indeed a file lock to prevent multiple solc versions from being installed at the same time, but that this file lock does not apply to creating the SVM directory.
This PR adds error hanlding to the
setup_data_dirfunction to handle a race condition to create the SVM directory.