chore(registry): Dogfood Test Rollup Config #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refcell
added
A-genesis
📚
|
refcell
added
A-registry
mattsse
requested changes
Nov 23, 2024
| @@ -55,6 +55,19 @@ pub struct HardForkConfiguration { | |||
| pub holocene_time: Option<u64>, | |||
| } | |||
|
|
|||
| impl From<&RollupConfig> for HardForkConfiguration { | |||
There was a problem hiding this comment.
these types are in the same crate.
this impl would be less horrible if we also add this natively to RollupConfig.
I guess from<&> wouldn't be an issue for RollupConfig because we assume this will likely be Arc'ed.
but still, very much dislike standalone from ref impls
Comment on lines
-142
to
+137
| canyon_time: Some(1704992401), | ||
| delta_time: Some(1708560000), | ||
| ecotone_time: Some(1710374401), | ||
| fjord_time: Some(1720627201), | ||
| granite_time: Some(1726070401), | ||
| holocene_time: None, | ||
| }, | ||
| hardfork_configuration: (&crate::configs::BASE_MAINNET_CONFIG).into(), |
| granite_time: Some(1726070401), | ||
| holocene_time: None, | ||
| }, | ||
| hardfork_configuration: (&crate::configs::BASE_MAINNET_CONFIG).into(), |
There was a problem hiding this comment.
Suggested change
| hardfork_configuration: (&crate::configs::BASE_MAINNET_CONFIG).into(), | |
| hardfork_configuration: crate::configs::BASE_MAINNET_CONFIG.hardfork_config(), |
is much nicer
There was a problem hiding this comment.
I see, that makes sense to me, will change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dogfoods the hardcoded test rollup config and uses the new
From<&RollupConfig> for HardForkConfiguration.