Optimism RPC Types #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eipt.rs accordingly.
… methods in receipt.rs
mattsse
reviewed
Apr 10, 2024
…te's transaction and alloy's header.
mattsse
requested changes
Apr 11, 2024
gakonst
requested changes
Apr 13, 2024
There was a problem hiding this comment.
the entire PR needs to re-export RPC types where needed, and extend them everywhere else, the requirement is "there must not be any duplicate types between the 2 crates"
i would start from the lower level crate whether it's consensus or rpc types from your POV and do that first, and you can do the other in separate PR
but def don't copy paste big structs around, find the extension fields and add them there
overall good start!
mattsse
requested changes
Apr 16, 2024
|
PR for making structs in the main alloy crate take generics: alloy-rs/alloy#573 |
|
Relevant issue: #5 |
zerosnacks
reviewed
Apr 25, 2024
zerosnacks
reviewed
Apr 25, 2024
zerosnacks
reviewed
Apr 25, 2024
zerosnacks
reviewed
Apr 25, 2024
zerosnacks
reviewed
Apr 25, 2024
Merged
|
keeping this open because we still need receipt types, but to make incremental progress I've extracted the things we definitely need to #6 can't push here because main branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Updating the repository with Optimism RPC types.
Solution
Implement the needed OP specific RPC types and re-export whenever feasible.
PR Checklist