Replace UnsignedTx and TxEnvelope with op types in Network impl
#121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
<!-- Thank you for your Pull Request. Please provide a description above and review the requirements below. Bug fixes and new features should include tests. Contributors guide: https://github.com/alloy-rs/core/blob/main/CONTRIBUTING.md The contributors guide includes instructions for running rustfmt and building the documentation. --> <!-- ** Please select "Allow edits from maintainers" in the PR Options ** --> ## Motivation EIP-4844 transactions are not supported on OP stack networks https://specs.optimism.io/protocol/exec-engine.html#ecotone-disable-blob-transactions ## Solution Removes 4844 variants from transaction and receipt consensus types. We still have those on RPC types, should we introduce op-specific RPC types? it would also unblock #121 <!-- Summarize the solution and provide any necessary context needed to understand the code change. --> ## PR Checklist - [ ] Added Tests - [ ] Added Documentation - [ ] Breaking changes
|
Do we still want this? |
|
lol arseni has front run this one too #215, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bug: deposit tx not covered by alloy transaction envelope and unsigned transaction types in
Networkimpl forOptimismSolution
Replaces alloy types for
Network::TxEnvelopeandNetwork::UnsignedTxwith OP typesOpTxEnvelopeandOpTypedTransactionrespectively.blocked by #27
PR Checklist