feat(provider): provider examples
#3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Pulled in the latest upstream changes and made a few slight stylistic changes |
mattsse
requested changes
Mar 15, 2024
gakonst
reviewed
Mar 15, 2024
Comment on lines
24
to
27
| let provider_with_signer = ProviderBuilder::<_, Ethereum>::new() | ||
| .signer(EthereumSigner::from(signer)) | ||
| .network::<Ethereum>() | ||
| .provider(RootProvider::new(rpc_client)); |
There was a problem hiding this comment.
Ideal UX here is alloy_network::Ethereum::builder().signer(signer).connect(anvil.endpoint()). We should strive to get to that, incl the gas / nonce filling layer being on by default with the option to turn it off with .manual() or something. cc @onbjerg @DaniPopes
There was a problem hiding this comment.
For now ::<_, Ethereum> and .network are not necessary anymore: alloy-rs/alloy#304
mattsse
requested changes
Mar 19, 2024
mattsse
approved these changes
Mar 21, 2024
| let rpc_client = RpcClient::new(Http::<Client>::new(anvil.endpoint().parse().unwrap()), false); | ||
| let provider_with_signer = ProviderBuilder::<_, Ethereum>::new() | ||
| .signer(EthereumSigner::from(signer)) | ||
| .network::<Ethereum>() |
There was a problem hiding this comment.
this shouldn't be necessary anymore
zerosnacks
requested changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
httpwsipcbuilder