Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: DynSolCall #632

Merged
merged 4 commits into from
Jun 18, 2024
Merged

feature: DynSolCall #632

merged 4 commits into from
Jun 18, 2024

Conversation

prestwich
Copy link
Member

Motivation

Continue fleshing out dyn-abi to reach feature parity with sol-types

Solution

  • Add DynSolCall
  • Add DynSolReturns
  • Add impl Specifier<DynSolCall> for Function

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added the enhancement New feature or request label May 22, 2024
@prestwich prestwich requested a review from DaniPopes May 22, 2024 09:51
@prestwich prestwich self-assigned this May 22, 2024
@prestwich
Copy link
Member Author

anyone know what's up with miri cancelling?

crates/dyn-abi/src/eip712/mod.rs Show resolved Hide resolved
crates/dyn-abi/src/ext/abi.rs Outdated Show resolved Hide resolved
@DaniPopes DaniPopes merged commit 5c71dda into main Jun 18, 2024
30 checks passed
@DaniPopes DaniPopes deleted the prestwich/dyn-func branch June 18, 2024 11:07
klkvr pushed a commit that referenced this pull request Aug 4, 2024
* feature: DynSolCall

* lint: clippy

* Update crates/dyn-abi/src/eip712/mod.rs

Co-authored-by: DaniPopes <[email protected]>

* fix: revert crates/dyn-abi/src/ext/abi.rs

---------

Co-authored-by: DaniPopes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants