New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow zero bytes parsing #401

Closed

klkvr wants to merge 1 commit into alloy-rs:main from klkvr:klkvr/zero-bytes-parsing

Member

klkvr commented Nov 3, 2023

Motivation

Right now alloy-rs is not able to coerce "0x" to bytes. It leads to this foundry issue, for example

Solution

Uses winnow::ascii::hex_digit0 instead of winnow::ascii::hex_digit1 which raises error when parsing empty strings

PR Checklist

[ x ] Added Tests
Added Documentation
Breaking changes


          Allow zero bytes parsing

4356d06

klkvr requested a review from prestwich as a code owner

November 3, 2023 20:56

klkvr closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet