feature: bytes handles numeric arrays and bytearrays in deser #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
reviewed
Jul 21, 2023
DaniPopes
reviewed
Jul 21, 2023
|
Gave the same treatment to |
DaniPopes
requested changes
Jul 25, 2023
Comment on lines
+62
to
+66
| hex::decode(v) | ||
| .map_err(|_| { | ||
| de::Error::invalid_value(de::Unexpected::Str(v), &"a valid hex string") | ||
| }) | ||
| .map(From::from) |
There was a problem hiding this comment.
Suggested change
| hex::decode(v) | |
| .map_err(|_| { | |
| de::Error::invalid_value(de::Unexpected::Str(v), &"a valid hex string") | |
| }) | |
| .map(From::from) | |
| v.parse() | |
| .map_err(|_| { | |
| de::Error::invalid_value(de::Unexpected::Str(v), &"a valid hex string") | |
| }) |
crates/primitives/src/bytes/serde.rs
Outdated
| where | ||
| A: serde::de::SeqAccess<'de>, | ||
| { | ||
| let mut bytes = Vec::new(); |
There was a problem hiding this comment.
DaniPopes
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #198
Motivation
Solution
PR Checklist