feat(dyn-abi): add arbitrary impls and proptests #175
Conversation
DaniPopes
force-pushed
the
dani/dyn-proptests
branch
from
865bed6
to
674ed23
Compare
DaniPopes
force-pushed
the
dani/dyn-proptests
branch
from
674ed23
to
a014e91
Compare
| EIP-712: | ||
|
|
||
| assert_eq!(decoded, my_values); | ||
| ```rust,ignore | ||
| todo!() | ||
| ``` |
There was a problem hiding this comment.
do we have an example for this anywhere? if not can you add one @prestwich
There was a problem hiding this comment.
I'm still stewing on the interface, so i haven't wanted to write an example that will churn. the basic thing right now is "just deser the json"
| #[inline] | ||
| pub fn as_tuple(&self) -> Option<&[Self]> { | ||
| match self { | ||
| Self::Tuple(t) => Some(t), |
There was a problem hiding this comment.
should this use the. as_tuple macro or have similar behavior?
There was a problem hiding this comment.
No I think the as_<variant> should only return the variant
crates/dyn-abi/src/ty.rs
Outdated
| } | ||
| } | ||
|
|
||
| /// Returns wheter this type is contains a custom struct. |
There was a problem hiding this comment.
wheter
should this function only exist if the feature is enabled?
There was a problem hiding this comment.
I want these to be available always, cfg is already annoying as it is with just one variant, especially inside of this crate itself
| /// Fallible cast to the contents of a variant. | ||
| #[inline] | ||
| #[allow(clippy::missing_const_for_fn)] | ||
| pub fn as_custom_struct(&self) -> Option<(&str, &[String], &[Self])> { |
There was a problem hiding this comment.
should this function only exist if the feature is enabled?
Motivation
::arbitraryandproptest) for dyn-abi enums and fuzz test them withproptest.DynSolType::{parse,sol_type_name}Solution
PR Checklist