Significant dyn-abi fixes :) #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
commented
Jul 2, 2023
|
|
||
| self.decode_sequence_populate(&mut child)?; | ||
|
|
||
| if !dynamic { |
There was a problem hiding this comment.
bug: missed offset propagation resulted in bad decoding
prestwich
commented
Jul 2, 2023
| @@ -470,16 +470,23 @@ impl DynSolValue { | |||
| } | |||
|
|
|||
| if let Some(vals) = self.as_fixed_seq() { | |||
| return self.is_dynamic() as usize * vals.len() | |||
| return self.is_dynamic() as usize * vals.iter().map(Self::total_words).sum::<usize>() | |||
There was a problem hiding this comment.
bug: incorrect tail words for fixed seqs
prestwich
commented
Jul 2, 2023
| } | ||
|
|
||
| if let Some(vals) = self.as_array() { | ||
| return 1 + vals.iter().map(Self::tail_words).sum::<usize>() | ||
| // 1 for the length. Then all words for all elements. | ||
| return 1 + vals.iter().map(Self::total_words).sum::<usize>() |
There was a problem hiding this comment.
bug: incorrect tail words for dyn seqs
DaniPopes
requested changes
Jul 2, 2023
prestwich
changed the title
prestwich
commented
Jul 3, 2023
| @@ -202,7 +203,11 @@ impl<'a> TryFrom<&'a str> for TupleSpecifier<'a> { | |||
| _ => {} | |||
| } | |||
| } | |||
| types.push(value[start..].try_into()?); | |||
| // handle termina commas in tuples | |||
| let candidate = value[start..].trim(); | |||
There was a problem hiding this comment.
this was a bug. for (T,) it would include the blank string, which would fail parsing into a typespecifier
DaniPopes
requested changes
Jul 3, 2023
DaniPopes
requested changes
Jul 3, 2023
DaniPopes
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #167
Motivation
Branch was initially to add tests to dyn-abi. Uncovered a few bugs
Solution
DynToken::FixedSeqdecodingDynSolValue::tail_wordsimpl for fixed and dyn sequencesDecoderDynSolValue::total_words(bool,)single-element tuples in dyn sol type parserPR Checklist