Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eips): make sha2 optional, add kzg-sidecar feature #949

Merged
merged 1 commit into from
Jun 20, 2024
Merged

chore(eips): make sha2 optional, add kzg-sidecar feature #949

merged 1 commit into from
Jun 20, 2024

Conversation

DaniPopes
Copy link
Member

No description provided.

mattsse
mattsse reviewed Jun 20, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we use this without c-kzg feature in some places

@DaniPopes DaniPopes force-pushed the dani/eips-sha2 branch 2 times, most recently from f8b6eb2 to 31b04aa Compare June 20, 2024 13:07
@DaniPopes DaniPopes changed the title chore(eips): make sha2 optional under kzg chore(eips): make sha2 optional Jun 20, 2024
@DaniPopes DaniPopes force-pushed the dani/eips-sha2 branch 3 times, most recently from 6b335ad to 3feb3c4 Compare June 20, 2024 13:19
@DaniPopes DaniPopes changed the title chore(eips): make sha2 optional chore(eips): make sha2 optional, add kzg-sidecar feature Jun 20, 2024
@DaniPopes DaniPopes force-pushed the dani/eips-sha2 branch 2 times, most recently from 6b653b0 to 8472b33 Compare June 20, 2024 13:22
mattsse
mattsse approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense

@DaniPopes DaniPopes merged commit b3b5828 into main Jun 20, 2024
22 checks passed
@DaniPopes DaniPopes deleted the dani/eips-sha2 branch June 20, 2024 13:57
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
@DaniPopes
chore(eips): make sha2 optional, add kzg-sidecar feature (alloy-r…
5971e4d 
…s#949)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @mattsse