feat(provider): expose ProviderBuilder via fn builder()
#858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
mattsse
reviewed
Jun 10, 2024
DaniPopes
approved these changes
Jun 11, 2024
| @@ -36,6 +37,12 @@ impl<T: fmt::Debug, N> fmt::Debug for RootProvider<T, N> { | |||
| } | |||
| } | |||
|
|
|||
| /// Helper function to directly access [`ProviderBuilder`] with minimal | |||
| /// generics. | |||
| pub fn builder<N: Network>() -> ProviderBuilder<Identity, Identity, N> { | |||
There was a problem hiding this comment.
I think this should be ethereum network like in ProviderBuilder::new?
There was a problem hiding this comment.
That would create cyclic deps
There was a problem hiding this comment.
How? It's right there in the imports in this file
There was a problem hiding this comment.
Oh wait, I read that as it should be "in ethereum network", as in the network crate.
There was a problem hiding this comment.
I think this should be ethereum network like in
ProviderBuilder::new?
Cannot set defaults in a free function.
|
pending @mattsse or @prestwich |
prestwich
approved these changes
Jun 11, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
…#858) * feat(provider): expose `ProviderBuilder` via `fn builder()` * feat(provider): free builder<N>() fn * nit * AnyNetwork test for builder fn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #450
Solution
Add
fn builder() -> ProviderBuilderin theProvidertrait.@prestwich @mattsse ptal
PR Checklist