chore(provider): document privileged status of EIP-1559 #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
mattsse
reviewed
Jun 7, 2024
|
there's a bit of nuance here. The thing I'm trying to express is that we assume that any chain we run the network abstraction over has the 1559 estimation end points and transactions will have 1559 fields. Which is to say that the network abstraction allows, encapsulating a lot of different behavior behind different traits, but it doesn't encapsulate 1559 at all it's complicated to provide another example 🤔 |
prestwich
force-pushed
the
zerosnacks/document-eip-1559-privileged-status
branch
from
7942378 to
d3378ae
Compare
prestwich
approved these changes
Jun 10, 2024
prestwich
force-pushed
the
zerosnacks/document-eip-1559-privileged-status
branch
from
d3378ae to
8a7b98e
Compare
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* document priviledged status of EIP-1559 * fix typo * hf -> tx type * doc: update 1559 note --------- Co-authored-by: James <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #371
Solution
Adds notice on
ProvidertraitPR Checklist