Reexport the reqwest.
#715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathieuDutSik
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
3 tasks
|
Closing in favor of #716, which re-exports reqwest and hyper from the relevant crate |
|
Thank you, the chosen solution is satisfying to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
reqwestlibrary is used by thealloylibrary. This means that the related types leak into other codes.Motivation
The type leakage is a problem in the rest of the code. For example we can have
This can be done via adding a
reqwestin theCargo.tomlfile but it has to match the version used inalloyand that is an unfortunate dependency.Solution
Replace
use reqwest as _bypub use reqwest.PR Checklist