feat: manual blob deserialize #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested review from
DaniPopes,
gakonst,
onbjerg,
prestwich and
Evalir
as code owners
mattsse
force-pushed
the
matt/manual-blob-deserialize
branch
from
088ee53 to
c0358b1
Compare
DaniPopes
reviewed
May 6, 2024
crates/eips/src/eip4844/sidecar.rs
Outdated
| @@ -21,6 +21,7 @@ use alloc::vec::Vec; | |||
| )] | |||
| pub struct BlobTransactionSidecar { | |||
| /// The blob data. | |||
| #[cfg_attr(feature = "serde", serde(deserialize_with = "deserialize_blobs"))] | |||
There was a problem hiding this comment.
plus debug_assertions
this is not a problem with opt-level > 0
There was a problem hiding this comment.
unclear what you're referring to here
There was a problem hiding this comment.
cfg_attr(all(feature,debug_assertions)
DaniPopes
reviewed
May 6, 2024
DaniPopes
approved these changes
May 6, 2024
Co-authored-by: DaniPopes <[email protected]>
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* feat: manual blob deserialize * use debug_assertions * Update crates/eips/src/eip4844/sidecar.rs Co-authored-by: DaniPopes <[email protected]> --------- Co-authored-by: DaniPopes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should prevent stackoverflows on sidecar deserde, ref https://github.com/foundry-rs/foundry/actions/runs/8968170602/job/24627087079?pr=7868
I assume this could be improved further by implementing a custom visitor, but will followup separately