Specific Configs to GethDebugTracerConfig + generic config build method for GethDebugTracingOptions #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c build method for config on GethDebugTracingOptions
halo3mic
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
DaniPopes
approved these changes
May 5, 2024
|
cc @mattsse |
mattsse
requested changes
May 13, 2024
|
@halo3mic are you still on this? Else I can take this over, we'd like to wrap it up |
Hey, @yash-atreya yea I did the changes that were requested in the latest commit. Should've replied saying changes were made, sorry! |
mattsse
approved these changes
May 22, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
…od for GethDebugTracingOptions (alloy-rs#686) * add conversion from specific config to GethDebugTracerConfig + generic build method for config on GethDebugTracingOptions * add back call_config & prestate_config helper functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
PR Checklist