fix: checking if the eip1559 gas fields are not set on eip2930 check #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loocapro
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
|
oh I forgot that 1559 includes access_list in its props. this will actually need more work because it means that 2930 should essentially never be the preferred type, as users will always expect 1559 😮💨 |
mattsse
reviewed
Apr 25, 2024
prestwich
force-pushed
the
fix/eip1559-tx-request
branch
from
e3ee3d2 to
6357361
Compare
|
@loocapro I made a couple quick touchups, including fixing the |
prestwich
approved these changes
Apr 27, 2024
mattsse
approved these changes
Apr 27, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
…lloy-rs#635) * fix: checking if the eip1559 gas fields are not set on eip2930 check * fix: some touchup to trim_conflicting --------- Co-authored-by: James <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes the bug documented in: #634
Solution
Added EIP1559 gas checks on the EIP2930 check.
PR Checklist