Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to geth 1.14 #628

Merged
merged 1 commit into from
Apr 24, 2024
Merged

chore: update to geth 1.14 #628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/scripts/install_test_binaries.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
#!/usr/bin/env bash
# Installs Solc and Geth binaries
# Installs Geth binary
# Note: intended for use only with CI (x86_64 Ubuntu, MacOS or Windows)
set -e

GETH_BUILD=${GETH_BUILD:-"1.13.15-c5ba367e"}
GETH_BUILD=${GETH_BUILD:-"1.14.0-87246f3c"}

BIN_DIR=${BIN_DIR:-"$HOME/bin"}

Expand Down
4 changes: 4 additions & 0 deletions crates/node-bindings/src/geth.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ impl GethInstance {
}

/// Returns the private key used to configure clique on this instance
#[deprecated = "clique support was removed in geth >=1.14"]
pub fn clique_private_key(&self) -> &Option<SigningKey> {
&self.clique_private_key
}
Expand Down Expand Up @@ -301,6 +302,7 @@ impl Geth {
///
/// The address derived from this private key will be used to set the `miner.etherbase` field
/// on the node.
#[deprecated = "clique support was removed in geth >=1.14"]
pub fn set_clique_private_key<T: Into<SigningKey>>(mut self, private_key: T) -> Self {
self.clique_private_key = Some(private_key.into());
self
Expand Down Expand Up @@ -726,6 +728,8 @@ mod tests {
}

#[test]
#[ignore = "fails on geth >=1.14"]
#[allow(deprecated)]
fn clique_correctly_configured() {
run_with_tempdir(|temp_dir_path| {
let private_key = SigningKey::random(&mut rand::thread_rng());
Expand Down
Loading