feature: WalletProvider #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
Evalir
as code owners
mattsse
requested changes
Apr 18, 2024
crates/provider/src/wallet.rs
Outdated
Comment on lines
14
to
23
| /// Get a reference to the underlying signer. | ||
| fn signer(&self) -> &Self::Signer; | ||
|
|
||
| /// Get a mutable reference to the underlying signer. | ||
| fn signer_mut(&mut self) -> &mut Self::Signer; | ||
|
|
||
| /// Get the default signer address. | ||
| fn default_signer(&self) -> Address { | ||
| self.signer().default_signer() | ||
| } |
There was a problem hiding this comment.
hmm, perhaps naming could be confusing here.
default_signer vs signer perhaps we should include _address in the fn name?
There was a problem hiding this comment.
I want to rename NetworkSigner to NetworkWallet, and LocalWallet to LocalSigner, and always use Wallet to mean "a collection of credentials" and signer to mean "a single credential". but that is a more extensive refactor
There was a problem hiding this comment.
opened a new issue #575
mattsse
approved these changes
Apr 18, 2024
prestwich
force-pushed
the
prestwich/signer-stack-trait
branch
from
7bf36b5 to
f407b5d
Compare
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* feature: WalletProvider * feature: signer_mut * test: a basic one * test: bubbles up * refactor: renames for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a trait that allows users to access the
NetworkSignerin a signing fill + provider stack.Motivation
Allow users to view keys and add signing credentials after building the provider stack.
Solution
Add a trait that exposes the underlying signer via borrows and mut borrows, and includes convenience functions for the useful
NetworkSignerfunctionsNote:
This trait is implemented only when both of the following are true:
Rfiller on the joinfill,These conditions are true for all stacks constructed by the builder. This is a bit non-intuitive, but is necessary to avoid conflicting impls when both L and R are signer provider and when multiple signers are present in a stack. While neither of those cases are expected ever, the type system allows for them. Therefore we cannot neatly describe this trait without the assumptions above
PR Checklist