fix: override txtype during submission prep #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
added
enhancement
prestwich
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
Evalir
as code owners
onbjerg
approved these changes
Apr 17, 2024
mattsse
approved these changes
Apr 17, 2024
DaniPopes
approved these changes
Apr 17, 2024
ThreeHrSleep
pushed a commit
to ThreeHrSleep/alloy
that referenced
this pull request
Apr 17, 2024
mattsse
added a commit
that referenced
this pull request
Apr 17, 2024
* Move BlockId type to alloy-eip * suggested changes * touchups * chore: touchups * fix: tmp fix for PendingTransactionBuilder::get_receipt (#558) * feat: add prague engine types (#557) * feat: add prague engine types * Update crates/eips/src/eip6110.rs Co-authored-by: DaniPopes <[email protected]> * clippy * Update crates/eips/src/eip6110.rs Co-authored-by: Oliver Nordbjerg <[email protected]> * Update crates/rpc-types-engine/src/exit.rs Co-authored-by: Oliver Nordbjerg <[email protected]> --------- Co-authored-by: DaniPopes <[email protected]> Co-authored-by: Oliver Nordbjerg <[email protected]> * fix: add more generics to any and receipt with bloom (#559) * fix: signer fills from if unset (#555) * fix: override txtype during submission prep (#556) * Use the same way to both serialize and deserialize `OptimismPayloadAttributes::gas_limit`. (#563) * Use the same way to both serialize and deserialize `OptimismPayloadAttributes::gas_limit`. I understand that `op-reth` only ever deserializes this structure. My use case is to serialize this struct and pass it to `op-geth`. The latter expects it to be hex. * rustfmt --------- Co-authored-by: Matthias Seitz <[email protected]> * feat: add ClientVersionV1 (#562) * added ClientVersionV1 * touchups * rustfmt --------- Co-authored-by: Matthias Seitz <[email protected]> * clippy * use alloc --------- Co-authored-by: Matthias Seitz <[email protected]> Co-authored-by: Arsenii Kulikov <[email protected]> Co-authored-by: DaniPopes <[email protected]> Co-authored-by: Oliver Nordbjerg <[email protected]> Co-authored-by: James Prestwich <[email protected]> Co-authored-by: Raman Hafiyatulin <[email protected]> Co-authored-by: guha-rahul <[email protected]>
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* Move BlockId type to alloy-eip * suggested changes * touchups * chore: touchups * fix: tmp fix for PendingTransactionBuilder::get_receipt (alloy-rs#558) * feat: add prague engine types (alloy-rs#557) * feat: add prague engine types * Update crates/eips/src/eip6110.rs Co-authored-by: DaniPopes <[email protected]> * clippy * Update crates/eips/src/eip6110.rs Co-authored-by: Oliver Nordbjerg <[email protected]> * Update crates/rpc-types-engine/src/exit.rs Co-authored-by: Oliver Nordbjerg <[email protected]> --------- Co-authored-by: DaniPopes <[email protected]> Co-authored-by: Oliver Nordbjerg <[email protected]> * fix: add more generics to any and receipt with bloom (alloy-rs#559) * fix: signer fills from if unset (alloy-rs#555) * fix: override txtype during submission prep (alloy-rs#556) * Use the same way to both serialize and deserialize `OptimismPayloadAttributes::gas_limit`. (alloy-rs#563) * Use the same way to both serialize and deserialize `OptimismPayloadAttributes::gas_limit`. I understand that `op-reth` only ever deserializes this structure. My use case is to serialize this struct and pass it to `op-geth`. The latter expects it to be hex. * rustfmt --------- Co-authored-by: Matthias Seitz <[email protected]> * feat: add ClientVersionV1 (alloy-rs#562) * added ClientVersionV1 * touchups * rustfmt --------- Co-authored-by: Matthias Seitz <[email protected]> * clippy * use alloc --------- Co-authored-by: Matthias Seitz <[email protected]> Co-authored-by: Arsenii Kulikov <[email protected]> Co-authored-by: DaniPopes <[email protected]> Co-authored-by: Oliver Nordbjerg <[email protected]> Co-authored-by: James Prestwich <[email protected]> Co-authored-by: Raman Hafiyatulin <[email protected]> Co-authored-by: guha-rahul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #552
Motivation
We don't want to rely on users to set the correct tx type pre-submission. We assume that other tx characteristics are more important than tx type, and essentially treat the tx type as a computed property
Solution
Modify
prep_for_submissionto override user-specifiedtx_typePR Checklist