fix: change Header::nonce to B64
#485
Conversation
klkvr
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
There was a problem hiding this comment.
hmm this is also u64 in reth https://github.com/paradigmxyz/reth/blob/main/crates/primitives/src/header.rs#L76-L78 , not sure we should change this to B64?
Also, I think the enabling default tls commit slipped in
yeah not sure if this should actually be u64 in consensus types it was B64 in rpc-types and reth is currently pinned to alloy commit which has it as B64 in rpc_types::Header: alloy/crates/rpc-types/src/eth/block.rs Line 104 in 6aab216 |
|
The spec defines it as bytes8 so it should definitely by serialized/deserialized as B64 https://github.com/ethereum/execution-apis/blob/90a46e9137c89d58e818e62fa33a0347bba50085/src/schemas/block.yaml#L72 |
* fix: change Block.nonce to B64 * clippy * tests
* fix: change Block.nonce to B64 * clippy * tests
Motivation
It was changed to u64 by accident probably, this nonce is not the same entity as transaction nonce (it is a hash, not a number), and it is reported by RPC as a 8-byte hex string
Solution
PR Checklist