Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: convenience functions for nonce and gas on ProviderBuilder #378

Merged
merged 2 commits into from
Mar 24, 2024
Merged

feat: convenience functions for nonce and gas on ProviderBuilder #378

merged 2 commits into from
Mar 24, 2024
+37 −13

Conversation

leruaa
Copy link
Contributor

@leruaa leruaa commented Mar 23, 2024

Closes #373

prestwich
prestwich requested changes Mar 23, 2024
View reviewed changes
Copy link
Member

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the doctests for builder and the relevant layers? E.g. nonce.rs L30

@leruaa leruaa requested a review from prestwich March 23, 2024 21:40
@prestwich prestwich merged commit 28cab90 into alloy-rs:main Mar 24, 2024
17 checks passed
@leruaa leruaa deleted the provider_builder_convinence_methods branch October 10, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich prestwich approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Convenience functions for common layers
2 participants
@leruaa @prestwich