Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename RpcClient::prepare to request #299

Merged
merged 1 commit into from
Mar 13, 2024
Merged

chore: rename RpcClient::prepare to request #299

merged 1 commit into from
Mar 13, 2024

Conversation

DaniPopes
Copy link
Member

Closes #270

@DaniPopes DaniPopes requested a review from onbjerg March 13, 2024 14:45
mattsse
mattsse approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this better

@DaniPopes DaniPopes merged commit f95c672 into main Mar 13, 2024
15 checks passed
@DaniPopes DaniPopes deleted the dani/rename-prepare branch March 13, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg onbjerg approved these changes

@Evalir Evalir Awaiting requested review from Evalir

@prestwich prestwich Awaiting requested review from prestwich

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Rename RpcClientInner::prepare
3 participants
@DaniPopes @onbjerg @mattsse