Feat: 4844 SidecarBuilder #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
suggested changes
Mar 11, 2024
| /// Returns `Err(())` if there is an error. | ||
| fn decode_one<'a>(mut fes: impl Iterator<Item = WholeFe<'a>>) -> Result<Option<Vec<u8>>, ()> { | ||
| let first = fes.next().ok_or(())?; | ||
| let mut num_bytes = u64::from_be_bytes(first.as_ref()[1..9].try_into().unwrap()) as usize; |
There was a problem hiding this comment.
would be nice to have a method on WholeFe that does the array ref conversion, documented with assumptions about how WholeFe is constructed
There was a problem hiding this comment.
I'd prefer to omit, as reading from a WholeFe is generally not advisable. These should be a coder implementation detail, basically
prestwich
force-pushed
the
prestwich/sidecar-builder
branch
from
ace8a37 to
5dccace
Compare
prestwich
force-pushed
the
prestwich/sidecar-builder
branch
from
f64f1d4 to
249fb99
Compare
test: test ingestion feat: trim and inspect builder wip feat: modulus in 4844 feat: simple coder and ingestion strategies fix: required_fes in ingestion strategy refactor: names fix: clippy and doclinks fix: more doclinks and clippy fix: remove deref impls fix: delegate len and is_empty refactor: mutable sidecar coder
prestwich
force-pushed
the
prestwich/sidecar-builder
branch
from
6fe0b12 to
6fef96a
Compare
mattsse
reviewed
Mar 13, 2024
Comment on lines
35
to
38
| /// Create a new builder with a given capacity. | ||
| pub fn with_capacity(capacity: usize) -> Self { | ||
| let mut blobs = Vec::with_capacity(capacity); | ||
| blobs.push(Blob::new([0u8; BYTES_PER_BLOB])); |
There was a problem hiding this comment.
this also adds a new blob,
looking at the other function, I think this is intended
There was a problem hiding this comment.
yeah, the intention is to never allow the blobs vec to be empty
There was a problem hiding this comment.
i've improved instantiation quite a bit now :)
Rjected
approved these changes
Mar 14, 2024
mattsse
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is currently no convenient way to construct valid sidecars from data
Solution
Add a sidecar builder that ingests arbitrary data, blobs it, and builds into a sidecar
PR Checklist