Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(alloy): re-export alloy-core items individually #230

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

DaniPopes
Copy link
Member

Avoid glob re-export for better docs and source code

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think this is ok, gives us better control over what to re-export

Comment on lines +102 to +105
# TODO: Keep around until alloy-contract is stable.
# This should only be used in `alloy-contract` tests.
# [patch.crates-io]
# alloy-sol-macro = { git = "https://github.com/alloy-rs/core", rev = "18b0509950c90d9ec38f25913b692ae4cdd6f227" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be commented?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, currently there are no changes but it should be re enabled for testing with network changes

@DaniPopes DaniPopes merged commit ea8f4b0 into main Feb 22, 2024
14 checks passed
@DaniPopes DaniPopes deleted the dani/core-re-exports branch February 22, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants