providers: Add temporary bare Provider
#14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's make the tests use Anvil before merging this :) https://github.com/gakonst/ethers-rs/blob/01242ec614e384c9de9aee9effa2f3934ef04b4f/ethers-middleware/src/signer.rs#L470-L472 |
Evalir
force-pushed
the
evalir/add-new-provider
branch
from
c5deb1a to
2761995
Compare
Unfortunately deserialized untagged unions with RawValue does not work: serde-rs/json#497
gakonst
force-pushed
the
evalir/add-new-provider
branch
from
6c11fe7 to
0d92ed3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a temporary bare
Providerwhich we can use to integrate in Foundry while theNetworkRpcClientabstraction and trait settles, usingRpcClient. Theimplskeleton we have can be moved to theProvidertrait as well.This also fixes some bugs on the
json-rpccrate as well, mainly to make requests work on Anvil which has much more strict JSON-RPC parsing. In more detail:RequestPacketwas only sending the request params without the other fields (id, method, jsonrpc: 2.0), which I filed here: [Bug] JSON-RPC:RequestPacketserializes only the request portion, not the entire JSON-RPC request #15 and fixed with the payload typeResponsePacketwas unable to deserialize responses, as we need to manually implement the deserializer.We're using Anvil for tests, albeit it seems it breaks the MSRV policy as some things on ethers need 1.66.
PR Checklist