Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: no_std eth rpc types #1252

Merged
merged 8 commits into from
Sep 11, 2024
Merged

Conversation

refcell
Copy link
Contributor

@refcell refcell commented Sep 6, 2024

Description

Adds support for no_std in alloy-rpc-types-eth.

@refcell refcell marked this pull request as ready for review September 6, 2024 21:36
@DaniPopes
Copy link
Member

DaniPopes commented Sep 6, 2024

Can you update the workflow and no_std script from alloy-rs/core? Would like them to be the same

@refcell
Copy link
Contributor Author

refcell commented Sep 6, 2024

Can you update the workflow and no_std script from alloy-rs/core? Would like them to be the same

Yes definitely, mind if I do this in another PR to unblock this?

Might as well just fix it here 👍

@refcell refcell force-pushed the rf/feat/no-std-eth-rpc-types branch 2 times, most recently from c2c09f6 to 40645af Compare September 6, 2024 22:14
crates/rpc-types-eth/src/block.rs Outdated Show resolved Hide resolved
crates/rpc-types-eth/src/state.rs Outdated Show resolved Hide resolved
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending @DaniPopes

@refcell refcell force-pushed the rf/feat/no-std-eth-rpc-types branch from f29b04d to b627853 Compare September 10, 2024 13:19
@refcell refcell requested a review from DaniPopes September 10, 2024 14:17
@refcell refcell force-pushed the rf/feat/no-std-eth-rpc-types branch from 767305f to 6c46c61 Compare September 10, 2024 15:46
@mattsse mattsse merged commit 41b2fd2 into alloy-rs:main Sep 11, 2024
26 checks passed
lwedge99 pushed a commit to sentioxyz/alloy that referenced this pull request Oct 8, 2024
* feat: support no_std in alloy-rpc-types-eth

* feat: derive_more error

* ci: add no-std check

* ci: update script

* fix: crate collections

* fix: fmt

* chore: remove unused hash_map re-export

---------

Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants