Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Anvil builder default port #1213

Merged
merged 3 commits into from
Aug 31, 2024
Merged

fix: Anvil builder default port #1213

merged 3 commits into from
Aug 31, 2024

Conversation

MistApproach
Copy link
Contributor

Motivation

Anvil builder new() method docs states the default port to be 8545. In practice, however, current code sets random port number.

Solution

Set default port inside try_spawn() to 8545, unless otherwise specified.
Unit test added.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we actually want it to be assigned to a random port, otherwise the diff instances in tests will conflict entirely which where all of these failures come from

i'd update the docs instead

@MistApproach
Copy link
Contributor Author

Updated doc-comment for Anvil::new() instead.

@MistApproach MistApproach requested a review from onbjerg August 31, 2024 17:36
@onbjerg onbjerg merged commit 91d323f into alloy-rs:main Aug 31, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants