fix: use impl From<RangeInclusive> for FilterBlockOption
instead of Range
#1199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
FilterBlockOption
deals with inclusive ranges.alloy/crates/rpc-types-eth/src/filter.rs
Lines 171 to 179 in 02ccb77
While passing an exclusive range (eg
.select(start..end)
), it was wrongly including the end range in the filter.Solution
Only allow conversion from
RangeInclusive
instead ofRange
, since decrementing a block tag is not possible.