Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly trim eip7251 bytecode #1105

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented Jul 25, 2024

Motivation

The bytecode was incorrectly trimmed and started with an invalid opcode.

Solution

Correctly trim it based on #1103

closes #1103

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@onbjerg onbjerg added the bug Something isn't working label Jul 25, 2024
@onbjerg onbjerg marked this pull request as draft July 25, 2024 20:11
@onbjerg onbjerg force-pushed the onbjerg/eip7251-bytecode-trim branch from 8729b8a to f2b3813 Compare July 25, 2024 20:18
@onbjerg onbjerg marked this pull request as ready for review July 25, 2024 20:19
@mattsse mattsse merged commit 2de4e23 into main Jul 25, 2024
22 checks passed
@mattsse mattsse deleted the onbjerg/eip7251-bytecode-trim branch July 25, 2024 21:02
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] eip7251 has incorrect consolidation predeploy code
2 participants