feat(alloy): add "full" feature flag
#877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rpc flags internally but require the user to import the rpc client for WsConnect / IpcConnect manually
2 tasks
zerosnacks
commented
Jun 12, 2024
Comment on lines
+76
to
+88
| full = [ | ||
| "consensus", | ||
| "contract", | ||
| "eips", | ||
| "k256", | ||
| "kzg", | ||
| "network", | ||
| "provider-http", # includes `providers` | ||
| "provider-ws", # includes `providers` | ||
| "provider-ipc", # includes `providers` | ||
| "rpc-types", # includes `rpc-types-eth` | ||
| "signer-wallet", # includes `signers` | ||
| ] |
There was a problem hiding this comment.
In examples we did not need any specific flags from core as all commonly used functionality is already available by default
|
Moving to review, open to feedback / suggestions |
zerosnacks
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
gakonst
approved these changes
Jun 12, 2024
mattsse
approved these changes
Jun 12, 2024
| "contract", | ||
| "eips", | ||
| "k256", | ||
| "kzg", |
There was a problem hiding this comment.
imo this makes sense to include in full
full will probably include more stuff than necessary but for convenience this is okay imo.
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* add initial setup, make sure to enable rpc-client when setting rpc-client-ws flag * fix `alloy-serde` definition in `serde` flag * re-export alloy_rpc_client as client in the provider as we enable the rpc flags internally but require the user to import the rpc client for WsConnect / IpcConnect manually * only selectively enable WsConnect, IpcConnect - make available in root * add eips and kzg for 4844 tx and access lists * remove rpc-client from list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #876
Solution
rpc-clientwhen enablingrpc-client-wsso that you do not also need to add therpc-clientflag if you ifrpc-client-wsis used. This behavior is in line with the other feature flags.rpc-clientfeatures (WsConnect) and (IpcConnect) directly available (if defined as flag) on the provider. Previously this required separately defining therpc-clientflag and importing it from therpc::clientnamespace.Related PR (see impact of proposed changes): alloy-rs/examples#106
PR Checklist