Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add "full" feature flag to alloy meta-crate #876

Closed
zerosnacks opened this issue Jun 12, 2024 · 3 comments · Fixed by #877
Closed

[Feature] Add "full" feature flag to alloy meta-crate #876

zerosnacks opened this issue Jun 12, 2024 · 3 comments · Fixed by #877
Assignees
Labels
enhancement New feature or request

Comments

@zerosnacks
Copy link
Member

zerosnacks commented Jun 12, 2024

Component

alloy

Describe the feature you would like

Should:

  • Include all the core re-exports
  • Features:
full = [
    "consensus",
    "contract",
    "eips",
    "k256",
    "kzg",
    "network",
    "provider-http", # includes `providers`
    "provider-ws",   # includes `providers`
    "provider-ipc",  # includes `providers`
    "rpc-types",     # includes `rpc-types-eth`
    "signer-wallet", # includes `signers`
]

Additional context

cc @gakonst

@zerosnacks zerosnacks added the enhancement New feature or request label Jun 12, 2024
@zerosnacks zerosnacks self-assigned this Jun 12, 2024
@zerosnacks zerosnacks changed the title [Feature] Add "full" feature flag to alloy meta-crate [Feature] Add "full" feature flag to alloy meta-crate Jun 12, 2024
@zerosnacks
Copy link
Member Author

Notes:

  • rpc-types enables rpc-types-eth and rpc implicitly
  • signer-wallet enables signers implicitly

@prestwich
Copy link
Member

why is rpc-client on the list?

@zerosnacks
Copy link
Member Author

zerosnacks commented Jun 12, 2024

why is rpc-client on the list?

It was previously required to import WsConnect and IpcConnect when not using on_builtin, updated here: https://github.com/alloy-rs/alloy/pull/877/files

See context: https://github.com/alloy-rs/examples/pull/106/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants