Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add with_base_fee for TransactionInfo #721

Merged
merged 2 commits into from
May 10, 2024
Merged

add with_base_fee for TransactionInfo #721

merged 2 commits into from
May 10, 2024

Conversation

tcoratger
Copy link
Contributor

For situation where TransactionInfo is built from Transaction, base_fee field is set to None. As a result, it is interesting to have a with_base_fee method implemented in order to consume the created TransactionInfo instance and populate its base_fee field.

mattsse
mattsse requested changes May 10, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supportive, while we're at it, can we also add excess_blob_gas: Option<u64> here. this is needed to calc the blob gas price

pedantic clippy

@tcoratger
Copy link
Contributor Author

supportive, while we're at it, can we also add excess_blob_gas: Option<u64> here. this is needed to calc the blob gas price

pedantic clippy

Fixed :)

@prestwich prestwich merged commit 890acea into alloy-rs:main May 10, 2024
24 checks passed
@tcoratger tcoratger mentioned this pull request May 10, 2024
Closed
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
@tcoratger
add with_base_fee for TransactionInfo (alloy-rs#721)
0fbcfe2 
* add with_base_fee for TransactionInfo

* fix clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcoratger @mattsse @prestwich