TypeTransaction conversion trait impls #472
Conversation
yash-atreya
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
|
|
||
| impl From<TxEnvelope> for TransactionRequest { | ||
| fn from(envelope: TxEnvelope) -> TransactionRequest { | ||
| match envelope { |
There was a problem hiding this comment.
we could attempt to extract from from the signature here (ignoring any error on the ecdsa recovery)
There was a problem hiding this comment.
recover_signer is gated behind the k256 feature here. We can make k256 default in consensus or add cfg gate here. But I do not like adding so many cfg gates with different features. It makes the UX cumbersome. Curious to hear your view?
There was a problem hiding this comment.
it does make the UX cumbersome, but I also don't like dropping information that we definitely have and the user is likely to want if that makes sense
I wonder if it would make sense to extend the signed struct with signed_by: OnceLock<Address> which can be computed if K256 enabled
There was a problem hiding this comment.
Regardless, this decision shouldn't block the PR
There was a problem hiding this comment.
I wonder if it would make sense to extend the signed struct with signed_by: OnceLock
which can be computed if K256 enabled
If I'm not wrong, OnceLock enables lazy initialization, so this wouldn't affect performance even if the signer is recovered implicitly.
|
Ready to merge @prestwich ? |
| TxEnvelope::Legacy(tx) => { | ||
| #[cfg(feature = "k256")] | ||
| { | ||
| if let Ok(signer) = tx.recover_signer() { |
There was a problem hiding this comment.
let from = tx.recover_signer().ok();
let tx = tx.strip_signature().into()
if let Some(from) = from {
tx.from(from);
}
bit cleaner
Motivation
Ref #438
Solution
Add
Frombounds toUnsignedTxandTransactionRequesttypes inNetwork.Satisfy bounds by implementing the following:
From<TypedTransaction> for TransactionRequestFrom<TxEnvelope> for TransactionRequestFrom<TypedTransaction> for WithOtherFields<TransactionRequest>From<TxEnvelope> for WithOtherFields<TransactionRequest>To accomplish the above, implemented
From<TxLegacy> for TransactionRequestFrom<TxEip2930> for TransactionRequestFrom<TxEip1559> for TransactionRequestFrom<TxEip4844Variant> for TransactionRequestPR Checklist