Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Typed transaction conversion traits #438

Closed
7 tasks
prestwich opened this issue Apr 2, 2024 · 3 comments
Closed
7 tasks

[Feature] Typed transaction conversion traits #438

prestwich opened this issue Apr 2, 2024 · 3 comments
Labels
debt Tech debt which needs to be addressed enhancement New feature or request good first issue Good for newcomers

Comments

@prestwich
Copy link
Member

Component

consensus, eips, genesis

Describe the feature you would like

blocked by #433

add standard conversions to transaction types

  • modify Network
    • add a new bound: type UnsignedTx: From<Self::TxEnvelope>
    • add 2 new bounds: type TransactionRequest: From<Self::TxEnvelope> + From<Self::UnsignedTx>
  • satisfy new bounds
    • impl From<TxEnvelope> for TypedTransaction
    • impl From<TxEnvelope> for TransactionRequest
    • impl From<TypedTransaction for TransactionRequest

Additional context

No response

@prestwich prestwich added enhancement New feature or request good first issue Good for newcomers debt Tech debt which needs to be addressed labels Apr 2, 2024
@mahmudsudo
Copy link

can i take on this ?

@siosw
Copy link

siosw commented Nov 29, 2024

I think this has been completed in #472 should be closed

@mattsse
Copy link
Member

mattsse commented Nov 29, 2024

yep

@mattsse mattsse closed this as completed Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Tech debt which needs to be addressed enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants